Allow mount identifier, for MountManager of FlySystem library, into prefixes #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADmad
reviewed
Oct 11, 2021
| @@ -111,6 +111,17 @@ public function __construct(FilesystemOperator $source, FilesystemOperator $cach | |||
| $this->tempDir = sys_get_temp_dir(); | |||
| } | |||
|
|
|||
| private function trimPrefix(string $prefix): string | |||
| { | |||
| if ('//' == substr($prefix, -2)) { | |||
There was a problem hiding this comment.
Why not check for '://' === substr($prefix, -3) instead of having a separate check for :?
There was a problem hiding this comment.
Can you respond to above query please.
|
A little push to allow mount identifier into path without set prefix. If i set a cache prefix ; the mount identifier is removed. Example: set cache prefix "cache://my/dir" and get "img://my/img.jpg" , the cache path will be "cache://my/dir/my/img/jpg" |
|
Any news? Thx |
ADmad
reviewed
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow mount identifier, for MountManager of FlySystem library, into prefixes.