Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a solution for identifying future platforms #228

Open
theseion opened this issue Jan 12, 2018 · 9 comments
Open

Find a solution for identifying future platforms #228

theseion opened this issue Jan 12, 2018 · 9 comments

Comments

@theseion
Copy link
Owner

Possibilities:

  • FLFuturePlatform class
  • dedicated test case
  • auto generate new platform class
  • ?

Unfortunately, the current architecture relies on Metacello providing the platform identifiers and Metacello has the same problem.
In addition, even if we introduced something like an FLFuturePlatform class, it will at some point be necessary to create a new class specific to that platform, at the latest when the next platform version is up.

@astares
Copy link

astares commented Jan 12, 2018

see #227

@marianopeck
Copy link
Collaborator

Hi @theseion

Thanks for taking care of this. To me the easiest looks like a test case that acts as a reminder for us to create the class. As soon as a new Pharo release comes up, this test fill fail. Then we create the class and we are done.

@theseion
Copy link
Owner Author

This also requires removing the previous platform class in case of Pharo, as it's part of the core sources and will not automagically disappear (Fuel is not being loaded through the configuration / baseline).

@astares
Copy link

astares commented Jan 14, 2018

Usually we do not remove classes directly. We move them into Deprecated70 package so they will be still shipped (to stay compatible for a white and tell people not to use them anymore).

So when a new Pharo 8 start we then delete the Deprecated70 package and they are gone

@theseion
Copy link
Owner Author

I understand but the platform classes are not public. They are Fuel internals.

@astares
Copy link

astares commented Jan 14, 2018

OK. Fine!

@tinchodias
Copy link
Collaborator

Ah, doesn't Pharo 7 load Fuel via ConfigurationOfFuel?

A test seems enough, at least already an improvement.

@theseion
Copy link
Owner Author

No. Fuel is part of the pharo-project/pharo source.

@stale
Copy link

stale bot commented May 18, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will remain open but will probably not come into focus. If you still think this should receive some attention, leave a comment. Thank you for your contributions.

@stale stale bot added the stale label May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants