Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit always tries to commit to master #12

Closed
playpianolikewoah opened this issue Jan 25, 2016 · 4 comments
Closed

Commit always tries to commit to master #12

playpianolikewoah opened this issue Jan 25, 2016 · 4 comments
Labels

Comments

@playpianolikewoah
Copy link

On this line of your commit.js https://github.com/thisconnect/nodegit-kit/blob/master/lib/commit.js#L27
You reference Repository#getBranchCommit. You have master hard coded in there and I am not sure why.

@thisconnect
Copy link
Owner

Mainly because checkout and branch #2 is not implemented yet, NodeGitKit.commit currently does git commit -am"message". I think Repository#getHeadCommit would be correct and let you use a specific branch. Agree?

For NodeGitKit.diff I already have an internal api to get a commit and should support branch https://github.com/thisconnect/nodegit-kit/blob/master/lib/get.js

@thisconnect
Copy link
Owner

0.7.2 should work for you

@playpianolikewoah
Copy link
Author

Thanks @thisconnect. I'll check it out.

@thisconnect
Copy link
Owner

please reopen if the problem still exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants