Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add a progress bar for the Deconstruction/Reconstruction phase #106

Open
LukasQ opened this issue Aug 22, 2024 · 3 comments
Open

[ENH] Add a progress bar for the Deconstruction/Reconstruction phase #106

LukasQ opened this issue Aug 22, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@LukasQ
Copy link

LukasQ commented Aug 22, 2024

As a user of Slackord,
I want to see a progress bar during the data migration process, so that I know when the migration is complete and can avoid triggering the import to Discord prematurely, which currently causes InvalidOperation exceptions.

Acceptance Criteria:

  • A progress bar is displayed when initiating the data migration process in Slackord.
  • The progress bar accurately reflects the current status of the migration process.
  • The import to Discord cannot be initiated until the progress bar indicates that the migration process is 100% complete (e.g. discord slackord bot replies with "still migrating, please be patient"
  • If the migration process fails, the progress bar should indicate the failure and prevent any further action until the issue is resolved.

Definition of Done:

  • The progress bar is implemented and tested.
  • The feature has been reviewed and approved by the team.
  • User documentation is updated to reflect the new migration process.
  • No InvalidOperation exceptions occur due to premature data loading into Discord.
@thomasloupe
Copy link
Owner

Hi Lukas,

This feature was introduced in a previous version of Slackord, both for the import and posting process.

Were you, by chance, running into an issue where the JSON had been parsed, but the list had not been built fully, which then created an error in #105?

I believe I can definitely fix the issue of having the list population as part of the process in the progress bar. Currently, it only looks at the JSON parsing completion and the posting of messages until completion.

What I am getting from your ENH is to also include creation of the message list.
Am I correct in that assumption?

Thanks!

@LukasQ
Copy link
Author

LukasQ commented Aug 23, 2024

Were you, by chance, running into an issue where the JSON had been parsed, but the list had not been built fully, which then created an error in #105?

yes and

Am I correct in that assumption?

yes.
Its just a UX thing. Reading does do the trick, but as you offer enhancements, I believe this could be beneficial.

@thomasloupe
Copy link
Owner

I will look into getting this enhanced. Accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants