Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect language automatically according to browser preferences #181

Open
Quenix opened this issue Aug 28, 2020 · 1 comment
Open

Detect language automatically according to browser preferences #181

Quenix opened this issue Aug 28, 2020 · 1 comment

Comments

@Quenix
Copy link

Quenix commented Aug 28, 2020 •
edited
Loading

I've noticed that my main browser language is PT-BR but game instance is always loaded in english due to this validation:

messages.languageActive.hasOwnProperty(requestLang)

Because portuguese is added as pt-br and requestLang returns "pt".
Changing it through settings seems fine. I will create a fork to pull request this fix.
@adi-g15
Copy link
Contributor

adi-g15 commented Sep 25, 2020 •
edited
Loading

Just to link it with the PR, so that it shows that it's being worked upon 👍🏽 #182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Quenix @adi-g15