Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Glob blacklist dirs, add whitelist dirs #3293

Open
patmaddox opened this issue Nov 8, 2024 · 1 comment
Open

FR: Glob blacklist dirs, add whitelist dirs #3293

patmaddox opened this issue Nov 8, 2024 · 1 comment

Comments

@patmaddox
Copy link

I have a repo that pulls in lots of dirs named *.jj and *.git - sometimes these include BUILD files that are invalid for please. I would like please to support globbing blacklist dirs, and allowing whitelist dirs. Currently, please only works on fixed paths.

This would support a "default deny" workflow, while still permitting specific dirs.

I am up for trying to implement this, and want to start the discussion.

[parse]
blacklistdirs = "**/*.git"
blacklistdirs = "**/*.jj"

whitelistdirs = "important-project.git"
whitelistdirs = "important-projects/*.jj"
@toastwaffle
Copy link
Contributor

Hi Pat,

This seems like a reasonable change to make, as long as it can be made in a backwards compatible way. Unfortunately we're unlikely to have time to implement this any time soon, but if you have time to put together a pull request I'd be happy to review it!

@patmaddox patmaddox changed the title Feature: Glob blacklist dirs, add whitelist dirs FR: Glob blacklist dirs, add whitelist dirs Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants