Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Furnace crashes when attempting a WAV export (macOS and Android) #2068

Open
host12prog opened this issue Aug 6, 2024 · 3 comments
Open

Furnace crashes when attempting a WAV export (macOS and Android) #2068

host12prog opened this issue Aug 6, 2024 · 3 comments
Assignees
Labels
bug Something isn't working critical Requires urgent fixing

Comments

@host12prog
Copy link
Contributor

host12prog commented Aug 6, 2024

there are actually 2 variants:

  • variant 1: Furnace will crash BEFORE attempting to make a WAV file
  • variant 2: Furnace will crash AFTER attempting to make a WAV file (always guaranteed to happen)

how to reproduce variant 1:

  • open Furnace and immediately open a module
  • Song > Export > Audio > Export
  • there is a chance that Furnace will crash before rendering anything causing a corrupted WAV file

how to reproduce variant 2:

  • open Furnace and play the module (this prevents Furnace from crashing before it renders)
  • while the module is playing, Song > Export > Audio > Export
  • the song WILL render this time, but will crash after it is done rendering

on variant 2: Eknous did a bit of investigation and it appears that the app is segfaulting after rendering the WAV file, and has pinpointed it down to a line in src/audio/sdlAudio.cpp, line 49:

SDL_CloseAudioDevice(ai);

i haven't investigated variant 1, but i'd imagine that it is crashing because no audio devices have been opened, while in variant 2, an audio device HAS been opened (because of the playback), so it will render just fine

@host12prog host12prog changed the title Furnace on mobile crashes before OR after attempting a WAV export Furnace on mobile crashes when attempting a WAV export Aug 6, 2024
@tildearrow
Copy link
Owner

The problem is that I fail to reproduce this issue.
I wonder why does closing audio device result in a crash...

@freq-mod freq-mod added bug Something isn't working critical Requires urgent fixing labels Aug 9, 2024
@tildearrow tildearrow changed the title Furnace on mobile crashes when attempting a WAV export Furnace crashes when attempting a WAV export (macOS and Android) Aug 15, 2024
@tildearrow
Copy link
Owner

Build Git master. I have pushed a possible fix.

@tildearrow tildearrow self-assigned this Aug 23, 2024
@tildearrow tildearrow added the feedback Further information is requested label Aug 23, 2024
@tildearrow tildearrow removed the feedback Further information is requested label Aug 24, 2024
@tildearrow
Copy link
Owner

It still crashes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical Requires urgent fixing
Projects
None yet
Development

No branches or pull requests

3 participants