From acc5da22cacc51651af1d790428baca0b5db7c60 Mon Sep 17 00:00:00 2001
From: Kevin Turner <83819+keturn@users.noreply.github.com>
Date: Sun, 5 Jan 2020 14:20:13 -0800
Subject: [PATCH 1/2] test demonstrating failure of non-str object

---
 tests/test_core.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/test_core.py b/tests/test_core.py
index 516b394..d93c23c 100644
--- a/tests/test_core.py
+++ b/tests/test_core.py
@@ -690,7 +690,8 @@ def test_nested_styled_string_with_format():
     assert str(s) == '\033[31mHello \033[34mawesome\033[39m\033[31m world\033[39m'
 
 
-def test_styling_object_which_implements_str_proto():
+@pytest.mark.parametrize('colormode', [terminal.NO_COLORS, terminal.ANSI_8_COLORS])
+def test_styling_object_which_implements_str_proto(colormode):
     """
     Test styling an object which implements the str protocol
     """
@@ -698,7 +699,7 @@ class Dummy(object):
         def __str__(self):
             return 'I am a dummy object'
 
-    colorful = core.Colorful(colormode=terminal.ANSI_8_COLORS)
+    colorful = core.Colorful(colormode=colormode)
     assert str(colorful.black(Dummy())) == '\033[30mI am a dummy object\033[39m'
 
 

From d32dd3ab11f846f940258b562faef2eb035cbf45 Mon Sep 17 00:00:00 2001
From: Kevin Turner <83819+keturn@users.noreply.github.com>
Date: Sun, 5 Jan 2020 14:53:41 -0800
Subject: [PATCH 2/2] adding numbers makes an amusing failure case

It's sneaky because it gives different results when under NO_COLORS and
slips through without raising exceptions.
---
 tests/test_core.py | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/tests/test_core.py b/tests/test_core.py
index d93c23c..901d85c 100644
--- a/tests/test_core.py
+++ b/tests/test_core.py
@@ -703,6 +703,29 @@ def __str__(self):
     assert str(colorful.black(Dummy())) == '\033[30mI am a dummy object\033[39m'
 
 
+@pytest.mark.parametrize('colormode', [terminal.NO_COLORS, terminal.ANSI_8_COLORS])
+def test_styling_and_adding_numbers(colormode):
+    """
+    Test addition of styled objects that come from numbers.
+
+    A lot of the test_str_behavior things break, but numbers, addition,
+    and NO_COLORS is a relatively likely case and gives unexpected results
+    without throwing an exception.
+    """
+    colorful = core.Colorful(colormode=colormode)
+    n_left = 6543
+    n_right = 1234
+
+    added = colorful.black(n_left) + colorful.black(n_right)
+    # because __format__ and __str__ use different code paths, we might still
+    # get a str out of this without exception even if the str() test case erred.
+    s_added = "{}".format(added)
+
+    assert str(n_left) in s_added
+    assert str(n_right) in s_added
+    assert len(s_added) >= len(str(n_left)) + len(str(n_right))
+
+
 def test_str_behavior_for_colorfulstring():
     """
     Test that the ColorfulString object behaves like a str