Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Light Version #15

Open
stdavis opened this issue Feb 2, 2017 · 14 comments
Open

Light Version #15

stdavis opened this issue Feb 2, 2017 · 14 comments
Assignees
Milestone

Comments

@stdavis
Copy link

stdavis commented Feb 2, 2017

I have really enjoyed this theme! Thanks for all of your work!

Just suggesting that a light version would be great. I like to switch between light and dark depending on the time of day.

@tjkohli
Copy link
Owner

tjkohli commented Feb 3, 2017

I've been considering this idea, but it's interesting you say you like to switch with the time of day. Is sunset/sunrise usually when you switch?

Perhaps we can have an option to auto-switch the theme based on the time.

@tjkohli tjkohli self-assigned this Feb 3, 2017
@stdavis
Copy link
Author

stdavis commented Feb 3, 2017

Yes, generally I use Light during the daylight and Dark in the evenings. My desk faces some large windows. Auto switching based on sunrise/set would be ideal for me. Time of day would be less useful. Or just a toggle command would be great as well.

@tjkohli
Copy link
Owner

tjkohli commented Feb 3, 2017

What's your ideal place for a toggle command? In the Command Palette? Or is the theme configuration fine for you?

@stdavis
Copy link
Author

stdavis commented Feb 3, 2017

Ideal would be the command pallet. But theme config is what I currently do.

@tjkohli tjkohli added this to the 0.6.0 milestone Feb 10, 2017
@tjkohli
Copy link
Owner

tjkohli commented Feb 10, 2017

How about automatically changing it at Sunrise/Sunset in your current time zone? Or would that not be useful?

@stdavis
Copy link
Author

stdavis commented Feb 10, 2017

That would be awesome!

@tjkohli
Copy link
Owner

tjkohli commented Feb 11, 2017

No promises but I'll try my best.

There's apparently already a plugin that also does that, just FYI: https://atom.io/packages/sunset

@tjkohli tjkohli modified the milestones: 0.7.0, 0.6.0 Feb 17, 2017
@stdavis
Copy link
Author

stdavis commented Apr 10, 2017

Thanks for the recommendation on the sunset package. That's cool.

@tjkohli
Copy link
Owner

tjkohli commented Oct 13, 2017

@stdavis Hey, how is the theme holding up for you? There have been some new updates lately. Do you still want a light theme?

@stdavis
Copy link
Author

stdavis commented Oct 13, 2017

Hey @tjkohli. To be honest I hadn't looked at it in the while. I find myself rotating between a few different themes for variety. I took a look at your latest updates and it looks great!

Yes, I would still be interested in a light version of this theme. I now use sunset (thanks for the tip!) to switch based on sunset/rise to switch between light and dark themes.

@tjkohli
Copy link
Owner

tjkohli commented Oct 14, 2017

@stdavis Which light and dark themes do you use and why? I love hearing user feedback so I can improve Nebula.

@stdavis
Copy link
Author

stdavis commented Oct 30, 2017

I use one-light for my light theme. I like it because it's simple and the colors pop nicely for JS.

I used to use nebula for my dark theme but recently switch to one-dark. Only because of the new feature of automatically hiding the tab. It's jarring to have the tab hiding and showing every time I make changes to a file then save it. I don't like the fact that the line that I'm typing on moves up and down.

For example:
ywetteunii

I wish that there was a config that I could turn this feature off with. Otherwise, I've really enjoyed nebula.

@tjkohli
Copy link
Owner

tjkohli commented Oct 31, 2017

Please keep in mind that the up/down animation only happens if you have exactly one tab open. However, I was actually working on a preference for that feature. If you can hang in, it'll be released soon!

Edit: Done! @stdavis

@stdavis
Copy link
Author

stdavis commented Oct 31, 2017

Just upgraded and unchecked the box. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants