Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: display note name (like how a tuner does) #234

Open
wqking opened this issue Sep 6, 2022 · 3 comments
Open

Feature request: display note name (like how a tuner does) #234

wqking opened this issue Sep 6, 2022 · 3 comments
Labels
Feature request

Comments

@wqking
Copy link

wqking commented Sep 6, 2022

Thanks for the great project.

Currently Friture can display the frequency in the FFT spectrum view. It will be handy to display the note name (such as C4, D#5, Ab4, etc) for that frequency. It will be even better if there is a dedicated view for it. Also it will be nice to support transposed key.
celeste-sinead added a commit to celeste-sinead/friture that referenced this issue Mar 8, 2024
@celeste-sinead
Include note name in estimated pitch label.
416ae7c 
e.g. it might show "440Hz (A4)"
This should fulfill tlecomte#234
celeste-sinead added a commit to celeste-sinead/friture that referenced this issue Mar 14, 2024
@celeste-sinead
Include note name in estimated pitch label.
891253d 
e.g. it might show "440Hz (A4)"
This should fulfill tlecomte#234
@LiteApplication
Copy link
Contributor

@celeste-sinead could you please add the note name to the popup that shows up when you click on the graph ?

@celeste-sinead
Copy link
Contributor

celeste-sinead commented Mar 18, 2024 •
edited
Loading

@LiteApplication celeste-sinead/friture@6632f2d but I just noticed you did it yourself too 😆

I'm wondering if it needs to be configurable to get merged though.

@LiteApplication
Copy link
Contributor

Maybe, I just noticed the code was in python so I did it myself because I needed it quickly.
I created the pull request so that if you want to add it to your version you would not need to do it from scratch.

celeste-sinead added a commit to celeste-sinead/friture that referenced this issue May 4, 2024
@celeste-sinead
Include note name in estimated pitch label.
04a930c 
e.g. it might show "440Hz (A4)"
This should fulfill tlecomte#234
tlecomte pushed a commit that referenced this issue May 5, 2024
@celeste-sinead @tlecomte
Include note name in estimated pitch label.
6a85203 
e.g. it might show "440Hz (A4)"
This should fulfill #234
@celeste-sinead celeste-sinead mentioned this issue May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tlecomte @celeste-sinead @wqking @LiteApplication