Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out observability from run_tasks and run_tasks_base #206

Open
linear bot opened this issue Nov 13, 2024 · 0 comments
Open

Factor out observability from run_tasks and run_tasks_base #206

linear bot opened this issue Nov 13, 2024 · 0 comments

Comments

@linear
Copy link

linear bot commented Nov 13, 2024

Currently, run_tasks retrieves a default user from a database and uses its ID for telemetry. It would be nice to have telemetry completely factored out of the implementation of these functions and then injected from outside, for separation of concerns reasons and to facilitate testing.

This will also result in the opportunity to remove this line:

os.system(
"cp cognee/tests/integration/run_toy_tasks/data/cognee_db cognee/.cognee_system/databases/cognee_db"
)

from conftest.py in the run_toy_tasks integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants