You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now the current logic, is spaces uses the last Font found during the fallback. When you take into a string like Ride the Comet! ☄️ with even spaces on each side, the spacing is being used to help with padding. It should still properly center, however Emoji character spaces are a lot larger than say Helvetica.
I propose the line should be changed to RunFace = typeface;
The text was updated successfully, but these errors were encountered:
There are a couple of issues here that are affected by this logic.
In general I agree with @Gillibald however this was specifically was trying to prevent breaking a sequence of words that all require font replacement into separate font runs and thereby introducing a (probably redundant) font switch at each word boundary.
I'm not sure about replacing the spaces around emojis - seems their should be some more heuristics here but not sure what they should be.
Also, this may also affect alignment of font replacements in a fixed pitch base font. eg: see this example.
Right now the current logic, is spaces uses the last Font found during the fallback. When you take into a string like
Ride the Comet! ☄️
with even spaces on each side, the spacing is being used to help with padding. It should still properly center, however Emoji character spaces are a lot larger than say Helvetica.I propose the line should be changed to
RunFace = typeface;
The text was updated successfully, but these errors were encountered: