Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FullScreen & Mobile Controls for the Iframe Embed #322

Open
torch2424 opened this issue Mar 14, 2020 · 2 comments
Open

Implement FullScreen & Mobile Controls for the Iframe Embed #322

torch2424 opened this issue Mar 14, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@torch2424
Copy link
Owner

torch2424 commented Mar 14, 2020

relates to #320

The fullscreen button should just be in the control bar, and set the emulator to take the full screen, preserving the gameboy aspect ratio (160 x 144).

Mobile Controls UX will be difficult. Since, it is not possible to detect reliably if you are on a small device within an iframe. Need to find a way to make a mobile controls toggle that is obvious, but at the same time, not always visible obstructing the game view 🤔

@torch2424 torch2424 added enhancement New feature or request question Further information is requested labels Mar 14, 2020
@torch2424 torch2424 self-assigned this Mar 14, 2020
@torch2424
Copy link
Owner Author

torch2424 commented Mar 14, 2020

Here's one okay example: https://oldgameshelf.com/, But they just use the host site and show the controls upfront outside of their frame.

@torch2424
Copy link
Owner Author

We can do something similar to: https://www.retrogames.cc/

Let's show the mobile controls by default. but add a toggle button in the control bar at the bottom of the page. This way, it's super easy for desktop users to just turn it off, and mobile users will know they can play 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant