Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure instance cleanup runs even when context is cancelled #254

Open
5 tasks
sarahhodne opened this issue Jan 17, 2017 · 0 comments
Open
5 tasks

Ensure instance cleanup runs even when context is cancelled #254

sarahhodne opened this issue Jan 17, 2017 · 0 comments
Labels
backend/docker applies to the docker backend provider backend/gce applies to the gce backend provider backend/jupiterbrain applies to the jupiterbrain backend provider

Comments

@sarahhodne
Copy link
Contributor

We use context cancellations for things like shutdown with SIGTERM and timeouts, but some log messages seem to indicate that this could mean that the instance shutdown we do to clean up the instance after a cancellation doesn't finish. We should ensure that a context cancellation would still allow this cleanup to run.

Backends to check:

  • cloudbrain
  • docker
  • gce
  • jupiterbrain
  • local (this might not apply to this backend)
@meatballhat meatballhat added backend/jupiterbrain applies to the jupiterbrain backend provider backend/gce applies to the gce backend provider backend/docker applies to the docker backend provider labels Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend/docker applies to the docker backend provider backend/gce applies to the gce backend provider backend/jupiterbrain applies to the jupiterbrain backend provider
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sarahhodne @meatballhat