Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JWT authentication #113

Merged
merged 10 commits into from
May 3, 2024
Merged

Support JWT authentication #113

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7e6c22b
Unexport internal constants
nineinchnick Apr 29, 2024
fe72e9d
Improve README
nineinchnick Apr 29, 2024
209308c
Avoid using deprecated package ioutil
nineinchnick Apr 29, 2024
e7d1707
Fix linter errors
nineinchnick Apr 29, 2024
609c33d
Add token (JWT) authentication support
nineinchnick Apr 29, 2024
5aaef12
Enable TLS in test Trino container
nineinchnick Apr 30, 2024
1c7a55f
Add integration test for JWT auth
nineinchnick Apr 30, 2024
f951a6e
Dump container logs when it fails to become ready
nineinchnick Apr 29, 2024
e9cce0e
Use a real Trino server for TLS integration test
nineinchnick Apr 30, 2024
ef33b77
Start a stopped test container and fail quickly when it fails to start
nineinchnick Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Trino, and receive the resulting data.

* Native Go implementation
* Connections over HTTP or HTTPS
* HTTP Basic and Kerberos authentication
* HTTP Basic, and Kerberos authentication
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that looks weird

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Oxford comma?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW I ran the Vale linter on this Readme, same one we use for Trino docs

* Per-query user information for access control
* Support custom HTTP client (tunable conn pools, timeouts, TLS)
* Supports conversion from Trino to native Go data types
Expand Down Expand Up @@ -60,7 +60,7 @@ db, err := sql.Open("trino", dsn)

### Authentication

Both HTTP Basic and Kerberos authentication are supported.
Both HTTP Basic, and Kerberos authentication are supported.

#### HTTP Basic authentication

Expand Down Expand Up @@ -272,7 +272,7 @@ When reading response rows, the driver supports most Trino data types, except:
`time.Time`. All precisions up to nanoseconds (`TIMESTAMP(9)` or `TIME(9)`)
are supported (since this is the maximum precision Golang's `time.Time`
supports). If a query returns columns defined with a greater precision,
values will be trimmed to 9 decimal digits. Use `CAST` to reduce the returned
values are trimmed to 9 decimal digits. Use `CAST` to reduce the returned
precision, or convert the value to a string that then can be parsed manually.
* `DECIMAL` - returned as string
* `IPADDRESS` - returned as string
Expand Down Expand Up @@ -301,7 +301,7 @@ For two or three dimensional arrays, use `trino.NullSlice2Bool` and
`trino.NullSlice3Bool` or equivalents for other data types.

To read `ROW` values, implement the `sql.Scanner` interface in a struct. Its
`Scan()` function will receive a `[]interface{}` slice, with values of the
`Scan()` function receives a `[]interface{}` slice, with values of the
following types:
* `bool`
* `json.Number` for any numeric Trino types
Expand Down