Don't fail when decoding empty strings as floats in server responses #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a major issue in a project I'm working on ☝️ |
|
@eladitzhakian can you help with providing some reproduction steps? The test I added here is very synthetic. |
|
@nineinchnick in our use case it happens when trino is OOM while spawning a new query. set |
|
@nineinchnick any chance to push this for the next release? 🙏 |
|
I don't think so, the work here stalled. I don't have a good reproduction of the issue. |
nineinchnick
force-pushed
the
decode-float
branch
from
91d133e to
241bd0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116
I'm still not sure if the root cause is an empty string, that's why this is a draft.