You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hm, we also hard code the coordinates for the RectangularTank tests. Is it worth loading the coordinates from a separate file? It took me a while to generate this, and I need to generate this again for a csv file. Can we leave it as is and if it gets complicated we can still add a separate csv file. @efaulhaber what's your opinion on this?
On the other hand, it's a good point to put coordinates for setup tests in a separate csv file...
The text was updated successfully, but these errors were encountered:
efaulhaber
changed the title
Hm, we also hard code the coordinates for the RectangularTank tests. Is it worth loading the coordinates from a separate file? It took me a while to generate this, and I need to generate this again for a csv file. Can we leave it as is and if it gets complicated we can still add a separate csv file. @efaulhaber what's your opinion on this?
Shall we move long hard-coded coordinate arrays in the test files to separate files?
Apr 2, 2024
A quick thought on this: Most of these long arrays are three-liners, right? So when reading it in an editor without line-wrapping, it's just three lines that one can easily ignore.
A quick thought on this: Most of these long arrays are three-liners, right? So when reading it in an editor without line-wrapping, it's just three lines that one can easily ignore.
Hm, we also hard code the coordinates for the
RectangularTank
tests. Is it worth loading the coordinates from a separate file? It took me a while to generate this, and I need to generate this again for a csv file. Can we leave it as is and if it gets complicated we can still add a separate csv file. @efaulhaber what's your opinion on this?On the other hand, it's a good point to put coordinates for setup tests in a separate csv file...
Originally posted by @LasNikas in #437 (comment)
The text was updated successfully, but these errors were encountered: