We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not sure what the intention is here:
route-node/modules/RouteNode.ts
Lines 142 to 161 in 71fd8d9
But in the cb, the name field is overwritten by this fullName property.
cb
name
fullName
This is the only time in the entire lifecycle of the RouteNode where the name is obscured and overwritten as such.
RouteNode
Is this intentional? It's breaking code in router5 (and probably other places?) that rely on the callback.
router5
It seems extra bad that the node itself doesn't get this fullName property -- just the spread in this callback.
The text was updated successfully, but these errors were encountered:
router.add
No branches or pull requests
Not sure what the intention is here:
route-node/modules/RouteNode.ts
Lines 142 to 161 in 71fd8d9
But in the
cb
, thename
field is overwritten by thisfullName
property.This is the only time in the entire lifecycle of the
RouteNode
where the name is obscured and overwritten as such.Is this intentional? It's breaking code in
router5
(and probably other places?) that rely on the callback.It seems extra bad that the node itself doesn't get this
fullName
property -- just the spread in this callback.The text was updated successfully, but these errors were encountered: