Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-127111 / 24.04.1 / Grab netdata api log in debug (by Qubad786) #189

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

bugclerk
Copy link

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x c519b7fb7db10a801af2768b4f4487417a18fb7b

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x 1d43120bdec35cbe24793a87ea3fab63074f4d62

Context

We are logging netdata client errors to a separate file and this new log file should be grabbed in the debug as well to properly help diagnose.

Original PR: #188
Jira URL: https://ixsystems.atlassian.net/browse/NAS-127111

@Qubad786 Qubad786 marked this pull request as ready for review April 23, 2024 20:02
@Qubad786 Qubad786 force-pushed the NAS-127111-24.04.1 branch from 6680b6f to 6e511f9 Compare April 23, 2024 20:02
@Qubad786 Qubad786 requested a review from yocalebo April 23, 2024 20:03
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (stable/dragonfish@ee7a173). Click here to learn what that means.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             stable/dragonfish     #189   +/-   ##
====================================================
  Coverage                     ?   93.26%           
====================================================
  Files                        ?      101           
  Lines                        ?     2228           
  Branches                     ?        0           
====================================================
  Hits                         ?     2078           
  Misses                       ?      150           
  Partials                     ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yocalebo yocalebo merged commit 1069f52 into stable/dragonfish Apr 23, 2024
6 checks passed
@yocalebo yocalebo deleted the NAS-127111-24.04.1 branch April 23, 2024 20:30
@bugclerk
Copy link
Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants