Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130771 / 24.10-RC.1 / Add RedactedFileMetric and use to redact iSCSI CHAP secrets (by bmeagherix) #212

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

bugclerk
Copy link

Add RedactedFileMetric and use redact_chap_passwords callback to redact iSCSI CHAP secrets.

This will replace the secrets in the copy of /etc/scst.conf.

Original PR: #211
Jira URL: https://ixsystems.atlassian.net/browse/NAS-130771

(cherry picked from commit 83ed2d1)
(cherry picked from commit 98828e4)
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (stable/electriceel@0df5782). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel     #212   +/-   ##
=====================================================
  Coverage                      ?   91.83%           
=====================================================
  Files                         ?      103           
  Lines                         ?     2314           
  Branches                      ?        0           
=====================================================
  Hits                          ?     2125           
  Misses                        ?      189           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anodos325 anodos325 merged commit 9fa7a9c into stable/electriceel Aug 22, 2024
6 checks passed
@anodos325 anodos325 deleted the NAS-130771-24.10-RC.1 branch August 22, 2024 19:25
@bugclerk
Copy link
Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants