From 8c66fccc6e30e0853138e42eda0504312ca09af6 Mon Sep 17 00:00:00 2001 From: Umer Saleem Date: Wed, 11 Dec 2024 15:01:57 +0500 Subject: [PATCH] Do not retrieve hidden zpool properties zprop_iter provides an interface to iterate over all available zpool properties. To iterate over hidden zpool properties, show_all parameter should be set to true. Recently, dedupcached property was added as part of fast dedup support in ZFS. This property is quite expensive since it needs to calculate the total size of dedup table loaded into the ARC. This commit updates the show_all parameter passed to zprop_iter, and sets it to False, since we don't want to retrieve the dedupcached property. All other hidden zpool properties will not be retrieved either as part of zprop_iter. These properties include name, tname, maxblocksize, maxdnodesize, dedupditto and dedupcached. Signed-off-by: Umer Saleem --- libzfs.pyx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libzfs.pyx b/libzfs.pyx index 8a11303..224104a 100644 --- a/libzfs.pyx +++ b/libzfs.pyx @@ -3127,7 +3127,7 @@ cdef class ZFSPool(object): result = {} with nogil: - libzfs.zprop_iter(self.__iterate_props, proptypes, True, True, zfs.ZFS_TYPE_POOL) + libzfs.zprop_iter(self.__iterate_props, proptypes, False, True, zfs.ZFS_TYPE_POOL) for x in proptypes: prop = ZPoolProperty.__new__(ZPoolProperty)