NAS-131711 / 25.04 / Change snapdir type to str #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit openzfs/zfs@d34d4f9 added a new `disabled` value to the `snapdir` property. Since it can now return three possible strings, update its type to `str`, similar to other properties like `compression` and `acltype`.
bugclerk
changed the title
anodos325
approved these changes
Oct 10, 2024
amotin
approved these changes
Oct 11, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit openzfs/zfs@d34d4f9 added a new
disabledvalue to thesnapdirproperty. Since it can now return three possible strings, update its type tostr, similar to other properties likecompressionandacltype. Additionally, the parsing of thesnapdirproperty in py-libzfs was already broken before the zfs-2.3 update. It was supposed to returnTruewhen set tohiddenandFalsewhen set tovisible, but instead, it returnedNonefor both states.Scale Build: http://jenkins.eng.ixsystems.net:8080/job/master/job/custom/607/
API Test Run: http://jenkins.eng.ixsystems.net:8080/job/tests/job/api_tests/1280/