NAS-132636 / 25.04 / Upgrade to Angular 19 #11103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvasilenko
requested review from
AlexKarpov98
and removed request for
a team
bugclerk
changed the title
AlexKarpov98
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Watch mode started.
But there are some problems
- A lot of warnings in a terminal console
Screen.Recording.2024-12-02.at.22.54.10.mov
- Icons are jumping / Huge (see TrueNAS logo)
Screen.Recording.2024-12-02.at.22.55.02.mov
- Icons or something is jumping on other pages as well
Screen.Recording.2024-12-02.at.22.55.29.mov
- Slide in form is jumping with some content for a fraction of a second
Screen.Recording.2024-12-02.at.22.57.44.mov
- Charts seem to be broken a little bit
- Drag and drop seems to be broken (widgets)
Screen.Recording.2024-12-02.at.23.00.11.mov
|
I came here to see if you guys were also experiencing the CSS parsing issue during test runs. I debugged the |
|
@aervin Yeah, we had the same issue some time ago: |
added 13 commits
December 12, 2024 09:08
bvasilenko
force-pushed
the
NAS-132636
branch
from
2a9c0b1 to
d1a304a
Compare
|
@AlexKarpov98 everything's ready for review, except the drag & drop on the dashboard. This is to be resolved in another extra PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing:
Browse across the WebUI and ensure that it's not broken