Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132675 / 24.10.1 / Remove nvidia state and event handlers (by undsoft) #11131

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

bugclerk
Copy link
Contributor

@bugclerk bugclerk commented Dec 3, 2024

Testing:

There is no suitable machine for testing, but you can create an Electric Eel machine and update AppsSettingsComponent to have protected hasNvidiaCard$ = of(true);

Original PR: #11126
Jira URL: https://ixsystems.atlassian.net/browse/NAS-132675

@bugclerk bugclerk requested a review from a team as a code owner December 3, 2024 09:54
@bugclerk bugclerk requested review from AlexKarpov98 and removed request for a team December 3, 2024 09:54
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backported

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/24.10.1@1478fb8). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/24.10.1   #11131   +/-   ##
==================================================
  Coverage                   ?   79.96%           
==================================================
  Files                      ?     1571           
  Lines                      ?    51426           
  Branches                   ?     5933           
==================================================
  Hits                       ?    41121           
  Misses                     ?    10305           
  Partials                   ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit 8df9c74 into release/24.10.1 Dec 3, 2024
9 checks passed
@undsoft undsoft deleted the NAS-132675-24.10.1 branch December 3, 2024 16:05
@bugclerk
Copy link
Contributor Author

bugclerk commented Dec 3, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants