Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132995 / 25.04 / Implement iSCSI connections card #11169

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket.

Use m50 machine.

Result:
Screenshot 2024-12-11 at 18 08 28

Ask Brian Meagher to setup a iSCSI Connection to see an actual connection in the card. (see boom target as an example)

@AlexKarpov98 AlexKarpov98 self-assigned this Dec 11, 2024
@bugclerk bugclerk changed the title NAS-132995: Implement iSCSI connections card NAS-132995 / 25.04 / Implement iSCSI connections card Dec 11, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.69%. Comparing base (ecba8b5) to head (c44c631).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11169   +/-   ##
=======================================
  Coverage   82.69%   82.69%           
=======================================
  Files        1652     1653    +1     
  Lines       58334    58359   +25     
  Branches     5998     5998           
=======================================
+ Hits        48237    48262   +25     
  Misses      10097    10097           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexKarpov98 AlexKarpov98 marked this pull request as ready for review December 12, 2024 16:22
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner December 12, 2024 16:22
@AlexKarpov98 AlexKarpov98 requested review from RehanY147 and removed request for a team December 12, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants