Temp fix for #6 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, it appears that only NA is affected by this. |
|
It’s weird that the heater object is simply not in the response. Not sure how the official Volvo app is getting that info.. 🤔 GH-25 fixes the issue with features not being hidden. Maybe we can revise the temp fix by using that change and then disabling preclimatization by default? |
Good idea. Up for grabs! 😄 |
|
Created PR-27 which -- I think -- should disable the preclimatization feature by default on fresh installs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents errors being thrown when getting heater status while the "heater" object is missing. This is not a permanent fix, as the accessory will always be shown as OFF. However, this allows the user to turn the heater on or off, albeit with incorrect status reporting.