Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A way to filter sounds #639

Open
ghost opened this issue May 8, 2021 · 2 comments
Open

A way to filter sounds #639

ghost opened this issue May 8, 2021 · 2 comments
Labels
always-fresh Issues that will never become stale enhancement New feature or request priority/low

Comments

@ghost
Copy link

ghost commented May 8, 2021

It will be easy to choose sounds if I can filter them.

Filters by

  • Category ex. life,...
  • Mood ex. relax,...
  • Intensity ex. light,...
  • Current state ex. playing,...

Current state
Filter list based on sounds playing state. Rather than scrolling through out the list and modifying sounds, It is easy to filter only playing sounds and modify them.

🍻 cheers!

@ghost ghost added the enhancement New feature or request label May 8, 2021
@ashutoshgngwr
Copy link
Member

ashutoshgngwr commented May 8, 2021

The intensity only has a meaning when generating random presets. It indicates the number of sounds to use. All the other filters look good. UI as well. The menu item (button) placement might be a trouble because there's a play-pause toggle and cast icon that also goes there. As it also happens, the title bar is owned by the parent of the library component. We need to find a different placement for that button.

@ashutoshgngwr ashutoshgngwr added always-fresh Issues that will never become stale priority/medium labels May 8, 2021
@ashutoshgngwr
Copy link
Member

As it also happens, the title bar is owned by the parent of the library component. We need to find a different placement for that button.

I was wrong about it! Fragments can inflate menus to an activity owned toolbar.

https://developer.android.com/guide/fragments/appbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
always-fresh Issues that will never become stale enhancement New feature or request priority/low
Projects
None yet
Development

No branches or pull requests

1 participant