Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better log outputs for ecm_prep.py #404

Open
aspeake opened this issue Aug 25, 2024 · 2 comments
Open

Better log outputs for ecm_prep.py #404

aspeake opened this issue Aug 25, 2024 · 2 comments
Assignees
Milestone

Comments

@aspeake
Copy link
Collaborator

aspeake commented Aug 25, 2024

To help with debugging, update the following behavior for log messages:

  • write the ecm_prep log file (added here: Address minor issues #402) to CI artifacts after the integration test is run.
  • Enable log messages in ecm_prep.py to be optionally output to the console with the --verbose argument
@aspeake aspeake self-assigned this Aug 25, 2024
@trynthink
Copy link
Owner

@aspeake We also discussed exposing the log file contents in the STDOUT so that it would be immediately visible in the runner logs, possibly by using verbose mode (which doesn't currently have this behavior, but could be changed to support it). Did you conclude that it would be preferable to write the log file as an artifact instead?

@aspeake aspeake changed the title Write ecm_prep.py log file to CI artifacts Better log outputs for ecm_prep.py Aug 29, 2024
@aspeake
Copy link
Collaborator Author

aspeake commented Aug 29, 2024

@aspeake We also discussed exposing the log file contents in the STDOUT so that it would be immediately visible in the runner logs, possibly by using verbose mode (which doesn't currently have this behavior, but could be changed to support it). Did you conclude that it would be preferable to write the log file as an artifact instead?

Actually we did decide to output to the console with --verbose, I updated the issue to address both

@aspeake aspeake added this to the v1.1.0 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants