Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: SwiftUI version #130

Open
shinra-electric opened this issue Nov 3, 2023 · 4 comments
Open

Feature Request: SwiftUI version #130

shinra-electric opened this issue Nov 3, 2023 · 4 comments

Comments

@shinra-electric
Copy link

I was intending to help contribute to the UI of this project, but I only really know SwiftUI. (AppKit and UIKit are not very interesting to me).

I tried getting it up and running with SwiftUI on macOS but I failed miserably. I have a basic UI set up, but I'm not able to convert all the UIKit stuff and get a Metal view rendering.

Screenshot 2023-11-03 at 14 10 33

If you're not interested in SwiftUI, maybe you could give me a hand with porting it? Are you on a suitable discord channel?

@tsalvo
Copy link
Owner

tsalvo commented Nov 3, 2023

I've also really been wanting to port this to SwiftUI myself!

I do have another private repo where the emulation is up and running in SwiftUI, and the screen is drawn in a SwiftUI Canvas, but it's very slow and barebones in comparison. There might be a better way to improve the performance, or perhaps it could be a SwiftUI View that wraps the existing MetalKit view.

I could share that code with you if you're interested! You would be free to create your own fork, or use any of that code that might be useful to you in your own repo. Or I could add you as a contributor to the other repo, which may end up replacing this one if we can get things working better 😀

@shinra-electric
Copy link
Author

Sure, that would be great! I doubt I'd be able to figure out the performance issues, but it would be interesting to work on it.

Probably forking would be better for now, I don't want to mess up your repo.

@tsalvo
Copy link
Owner

tsalvo commented Nov 4, 2023

I just invited you to have access to the repo. Let me know if you need anything, and hopefully the code is of some help! I'm hoping to go back to it again and revisit the Canvas approach, but I've just been a little distracted lately 😅

@shinra-electric
Copy link
Author

shinra-electric commented Nov 4, 2023

Thanks. You gave me access to FlamencoSP which seems to be a Swift Package. Is that the right one...?

Edit: I was spamming comments here, but it's not the right place 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants