Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Body text is not showing completely it's cutting out. #103

Open
uasghar-smile opened this issue May 13, 2022 · 9 comments
Open

Body text is not showing completely it's cutting out. #103

uasghar-smile opened this issue May 13, 2022 · 9 comments

Comments

@uasghar-smile
Copy link

Hi I am having an issue while trying to send an email body text is not showing completely

@uasghar-smile
Copy link
Author

Hi @tschoffelen can you please assist me on this why my body text is not being shown completely.
Platform: "IOS"

@jahirfiquitiva
Copy link
Contributor

@tschoffelen @danielmark0116

We are facing this very same issue.

This is a text we are using to test:

! " # $ % & ' ( ) * + , - . / 0 1 2 3 4 5 6 7 8 9 : ; < = > ? @ A B C D E F G H I J K L M N O P Q R S T U V W X Y Z [ \ ] ^ _ ` a b c d e f g h i j k l m n o p q r s t u v w x y z { | } ~

These are the results of our tests:

Without encodeBody, or encodeBody: false

Apple Email Gmail Outlook
IMG_2504 IMG_2505 IMG_2506

With encodeBody: true

Apple Email Gmail Outlook
IMG_2507 IMG_2508 IMG_2509

In this one, I think spaces ( ) should not be encoded.

@github-actions github-actions bot added the stale label May 22, 2024
@tschoffelen tschoffelen removed the stale label May 22, 2024
Repository owner deleted a comment from github-actions bot May 22, 2024
@tschoffelen
Copy link
Owner

Thanks for testing that @jahirfiquitiva!

Ideally, I think we should customise if/how we encode the body based on the email client chosen, and deprecate the encodeBody parameter. I don't have time in the foreseeable future to work on this myself, but would be more than happy to accept a PR of course!

Copy link

This issue is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale label Jul 22, 2024
@jahirfiquitiva
Copy link
Contributor

This should not be marked as stale, the issue is still present

@github-actions github-actions bot removed the stale label Jul 23, 2024
@tschoffelen
Copy link
Owner

Heya @jahirfiquitiva! Happy to accept a PR to fix this, I am not currently using the email composer option of the lib myself, and don't have time to look into it at the moment

@jahirfiquitiva
Copy link
Contributor

@tschoffelen I don't feel confident in my react-native knowledge as to be able to provide a PR to fix this. But hopefully in the near future.

@pke
Copy link
Contributor

pke commented Sep 25, 2024

Spaces could be encoded as "+", I'll check if the clients support that.

@tschoffelen
Copy link
Owner

Yeah it seems to differ between clients - appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants