Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal]: Merge react-native-email-link and react-native-map-link to react-native-app-link #145

Open
pke opened this issue Sep 25, 2024 · 1 comment

Comments

@pke
Copy link
Contributor

pke commented Sep 25, 2024

I realised both packages are very similar, have similar API and simliar runtime behaviour.
Maybe (to reduce dependencies) we would merge them into a new package called react-native-app-link (react-native-app-links)?

@pke pke changed the title [Proposal]: Merge react-native-email-link and rn-map-link to react-native-app-link [Proposal]: Merge react-native-email-link and react-native-map-link to react-native-app-link Sep 25, 2024
@tschoffelen
Copy link
Owner

Hi there!

I like this concept, and it would help in the maintenance of the packages as well, but I do think there's some distinctions between how they work, and it might be nice to keep them separate to make it easier for people to find them when googling for either solution.

What we could do is merge them into a single repo, that still has two separate packages (yarn workspaces) that are deployed as individual packages, so that we can share logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants