Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added python 3.12 support #125

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Added python 3.12 support #125

merged 2 commits into from
Apr 24, 2024

Conversation

marcelometal
Copy link
Member

No description provided.

@marcelometal marcelometal changed the title Added python 3.12 support WIP:Added python 3.12 support Oct 16, 2023
@marcelometal marcelometal force-pushed the py3.12 branch 5 times, most recently from 61f01d3 to 5a4044c Compare November 8, 2023 19:58
Copy link

@andersondalmina andersondalmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alguns pontos que acho que precisam ser alterados:

  • o teste @test "use python version 3.11 as default with invalid PYTHON_VERSION" precisa ser atualizado para a versão default 3.12.0 agora.

  • o teste use python version 3.11 as default with invalid .python-version precisa ser atualizado para a versão default 3.12.0 agora.

Não entendi o erro no teste install from Pipfile.lock with custom pipenv, parece que a versão 2.7.18 não é mais suportada 🤔
ERROR: python version 2.7.18 is not supported.

@@ -273,6 +291,7 @@ EOF
assert_success

[[ "$output" == *"Using python version: 3.11.3 (PYTHON_VERSION environment variable (closest))"* ]]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nesse teste usando PYTHON_VERSION=3 não deveria pegar a ultima versão do python3, que agora seria a 3.12.0?

Suggested change
[[ "$output" == *"Using python version: 3.11.3 (PYTHON_VERSION environment variable (closest))"* ]]
[[ "$output" == *"Using python version: 3.12.0 (PYTHON_VERSION environment variable (closest))"* ]]

@morpheu morpheu changed the title WIP:Added python 3.12 support Added python 3.12 support Apr 24, 2024
@morpheu morpheu merged commit bdd9082 into tsuru:master Apr 24, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants