Steampipe should return file not found as error when the input file does not exist. Closes #1752 #3767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pskrbasu
changed the title
pskrbasu
force-pushed
the
1752-running-steampipe-query-file_not_foundsql-should-return-a-file-not-found-error
branch
from
3f2aa99 to
d811405
Compare
kaidaguerre
requested changes
Aug 25, 2023
pkg/workspace/workspace_queries.go
Outdated
| if err != nil { | ||
| return nil, nil, fmt.Errorf("error opening file '%s': %s", sqlString, err.Error()) | ||
| } | ||
| fileQuery, fileExists, err := w.getQueryFromFile(filePath) | ||
| if fileExists { | ||
| if err != nil { |
There was a problem hiding this comment.
move error check before if fileExists
pkg/workspace/workspace_queries.go
Outdated
| // (just return the empty query - it will be filtered above) | ||
| } | ||
| return fileQuery, nil, nil | ||
| } | ||
| // sqlString is not a file name that exists |
There was a problem hiding this comment.
// sqlString is not a file name that exists => // the argument cannot be resolved as an existing file
kaidaguerre
deleted the
1752-running-steampipe-query-file_not_foundsql-should-return-a-file-not-found-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file not found
empty file
query resource not found in mod
cant open file
