Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the specification allow, disallow, or does not specify to upload empty (content-lenght 0) files? #1122

Open
meidlinga opened this issue Apr 24, 2024 · 3 comments
Labels

Comments

@meidlinga
Copy link

meidlinga commented Apr 24, 2024

I have tried this, but currently the file gets handed to the storage handler (Azure in my case), which tries to upload it.
Subsequently this fails and the tus client request gets rejected.

So I was wondering, if tus servers should allow this in the first place, before filing a more specific bug eventually.

@Acconut
Copy link
Member

Acconut commented Apr 24, 2024

tus has always allowed empty uploads and just last week we received a similar question and added an explaining paragraph to the protocol: tus/tus-resumable-upload-protocol#197

Does it not work for the azurestore?

@meidlinga
Copy link
Author

meidlinga commented Apr 24, 2024

Thanks for pointing this out.

I my case, I see, that tusd tries to upload a zero-length blob, and the azure client fails.
I have not verified, I use the latest version though but looking at https://github.com/tus/tusd/blob/main/pkg/azurestore/azurestore.go I do not see a respective check before trying to upload.

I can test against master and file a respective bug with more information in the next days.

@Acconut
Copy link
Member

Acconut commented Apr 24, 2024

I can test against master and file a respective bug with more information in the next days.

That would be great! Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants