Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect basic performance metrics #1648

Closed
Tracked by #1622
yannham opened this issue Sep 29, 2023 · 1 comment
Closed
Tracked by #1622

Collect basic performance metrics #1648

yannham opened this issue Sep 29, 2023 · 1 comment
Assignees

Comments

@yannham
Copy link
Member

yannham commented Sep 29, 2023

As #1622 shows, it's not easy to profile the Nickel interpreter: most time is spend inserting and fetching from the environment, evaluating primitive operations, but this is what is expected from a Nickel program.

In order to better diagnose performance issues, we should add the required infrastructure to collect basic Nickel-specific metrics in the interpreter - insertion and fetch from the environment, average size of environments, environment cloning, thunks created, thunks forced, generated variables created, etc. - and a feature flag to enable collection and report.

@yannham
Copy link
Member Author

yannham commented Sep 29, 2023

Closed by #1633 #1635. Opened for tracking purpose and future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants