Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic animation loop #342

Open
mikebolt opened this issue Jun 21, 2017 · 6 comments
Open

automatic animation loop #342

mikebolt opened this issue Jun 21, 2017 · 6 comments

Comments

@mikebolt
Copy link
Contributor

mikebolt commented Jun 21, 2017

I suggest that we add a 'TWEEN.animate' convenience method. It would set up a simple requestAnimationFrame animation loop.

function animate(time) {
	requestAnimationFrame(animate);
	TWEEN.update(time);
}
requestAnimationFrame(animate);

In the documentation, we just need to tell users to use this method once before starting any tweens.

We might need a shim for Node.js.

@mikebolt mikebolt self-assigned this Jun 21, 2017
@siwel
Copy link
Contributor

siwel commented Jul 24, 2017

This sounds fairly handy to reduce boilerplate, and such. I have a few suggestions;

  • Gaurd against the animate function being called multiple times / ensure we don't end up with multiple animation loops ➰
  • Getter for the current state - looping / deactivate
  • Ability to stop the animation

Any thoughts?
Lewis

@trusktr
Copy link
Member

trusktr commented Sep 16, 2017

@mikebolt Can you post a sample of code that shows what you're thinking the usage would look like?

@claus
Copy link

claus commented Sep 22, 2020

I realize that this issue is old but i thought i let you know that i wrote a Proxy wrapper around tweenjs that does what you're asking for. Tweenjs API stays like it is, so you can call all its methods. Caveats: currently starts a rAF for every tween (it doesn't reuse a global one), and uses Proxy which might have performance implications (although it should be fine really).

https://codepen.io/claus/pen/vYGQwNO
https://gist.github.com/claus/b5e91bb35f64cd616b191cbf310387d1

Maybe it helps someone.

@trusktr
Copy link
Member

trusktr commented Oct 20, 2020

I think this would indeed make it easier for some cases, while still allowing those who need control to make their own loops.

I'm thinking that perhaps

  • Group would be in charge of making the rAF loop (given the user opts-in with new API, so current behavior stays the same, at least until we swap the behavior in a breaking release).
  • When Group has tweens to update, it starts a loop.
  • When the Group has no Tweens to update, it stops the loop.

@trusktr
Copy link
Member

trusktr commented Oct 20, 2020

Maybe we can overload the start method, so that if it is passed a boolean then it signifies whether a loop should automatically be used (defaulting to false until a breaking release):

tween
  .to(...)
  .start(true) // Causes its associated Group to use a loop

in a breaking change, we can change it to true by default, and people could opt-out:

tween
  .to(...)
  .start(false) // don't use a loop, we'll call `update` manually.

@trusktr
Copy link
Member

trusktr commented Apr 23, 2023

I think a better API would be to not override start(), and make it an option for the Tween.

const tween = new Tween({}, {duration: 1000, autoLoop: true})
  .start() // starts the loop (or uses its group's loop if in a group)

// ...later
tween.stop() // stops the loop

@trusktr trusktr changed the title Add a TWEEN.animate method that sets up the requestAnimationFrame loop. automatic animation loop Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants