Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help wanted :) #638

Closed
mikebolt opened this issue Mar 31, 2023 · 7 comments
Closed

Help wanted :) #638

mikebolt opened this issue Mar 31, 2023 · 7 comments

Comments

@mikebolt
Copy link
Contributor

Hi everyone. I haven't worked on this project in a long time due to work and other interests. I don't think I'm going to work on this much in the future, and because there hasn't been much development in the last few years it looks like we need some maintainers.

So, to current and previous maintainers, do you need me to change anything on GitHub or npm?

And, to anyone else reading this, if you have ever looked through the source code, or if you want to, then more help is definitely welcome.

I'm posting this here because https://github.com/tweenjs/discuss hasn't been used in a long time, but this conversation could be continued over there.

@trusktr
Copy link
Member

trusktr commented Apr 2, 2023

Hi @mikebolt. I'm still here. If someone else is interested in collaborating, I can help ramping up and discussing. Please do reach out!

https://github.com/tweenjs/discuss hasn't been used in a long time

I went ahead and archived that after putting a link to https://github.com/tweenjs/tween.js/discussions there.

@trusktr trusktr changed the title Need maintainers Help wanted :) Apr 23, 2023
@trusktr trusktr pinned this issue Apr 23, 2023
@mk965
Copy link
Collaborator

mk965 commented Apr 24, 2023

@mikebolt @trusktr

I really want to join. Please feel free to contact me if I can be of help.

@cuixiping
Copy link

I like this lib and may contribute some code some time. I am using tweenjs for my games.

@trusktr
Copy link
Member

trusktr commented Nov 16, 2023

@cuixiping @mk965 would be glad to have some help. If any ideas, please let me know. The issues list has some existing things to do. We need to fix

with higher priority.

@cuixiping
Copy link

cuixiping commented Nov 17, 2023

@trusktr
As my test, similar to #659 , but have some differences.

  • rename tween.esm.js to tween.mjs
  • rename tween.cjs.js to tween.cjs
  • modify package.json
    • set "main" as mjs file "dist/tween.mjs"
    • remove "module" field
    • modify file names in "exports" field
{
	...
	"type": "module",
	"main": "dist/tween.mjs",
	"types": "dist/tween.d.ts",
	"exports": {
		".": {
			"import": "./dist/tween.mjs",
			"require": "./dist/tween.cjs"
		}
	},
	...
}

My testing steps:

  • create a new folder and run npm init and then npm install @tweenjs/tween.js
  • create a index.mjs in this folder with content
import * as TWEEN from '@tweenjs/tween.js'
console.log(Object.keys(TWEEN));
  • create a index.cjs in this folder with content
const TWEEN = require('@tweenjs/tween.js')
console.log(Object.keys(TWEEN));
  • run node ./index.mjs works ok!
  • run node ./index.cjs works ok!

My node.js version is 16.16.0

@trusktr
Copy link
Member

trusktr commented Jan 15, 2024

Hey thanks @cuixiping! Can you test with the latest? .cjs.js was renamed to .cjs, but everything else should just work.

The new examples in examples/example-projects/nodejs-commonjs/ and examples/example-projects/nodejs-esmodules/ verify being able to import into Node.js with either CommonJS or ESM format, with code similar to what you wrote with console.log.

We did not need to rename the .esm.js to .mjs because .js is already treated as ESM with type: module in package.json. Maybe just tween.js would be a nicer name, but decided not to make a breaking change for that.

@trusktr
Copy link
Member

trusktr commented Jan 15, 2024

@cuixiping @mk965 added you both to the repo! Will close this for now.

If anyone else is interested to volunteer some time on this, aiming to move towards a feature like Timeline for managing timelines with tweens after simplifying some things, please reach out!

@trusktr trusktr closed this as completed Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants