Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testing via jest #5

Open
dkundel opened this issue Sep 13, 2019 · 5 comments
Open

Add testing via jest #5

dkundel opened this issue Sep 13, 2019 · 5 comments
Assignees
@dangilkerson
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest related contributions help wanted Extra attention is needed

Comments

@dkundel
Copy link
Member

dkundel commented Sep 13, 2019

We should add some basic testing using jest. This might require some refactoring to make the code a bit more testable.
@dkundel dkundel added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 13, 2019
@dkundel dkundel added the hacktoberfest Hacktoberfest related contributions label Oct 1, 2019
@dangilkerson
Copy link
Contributor

I'd like to work on this

@dkundel
Copy link
Member Author

dkundel commented Oct 1, 2019

That would be great :) let me know if you need anything from me!

@dangilkerson
Copy link
Contributor

Is there a reason node_modules are checked in?

@dkundel
Copy link
Member Author

dkundel commented Oct 1, 2019

Yes those are the production dependencies only. It's a GitHub actions thing. i described it in #6

dangilkerson added a commit to trycatchrepeat/actions-sms that referenced this issue Oct 2, 2019
@dangilkerson
Add tests using jest twilio-labs#5
f467e33
@dangilkerson
Copy link
Contributor

I exported a function in main to test since I wanted to minimize the changes in case there were other changes on going. Probably should pull the code out of main.js when things are stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dangilkerson dangilkerson

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest related contributions help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dangilkerson @dkundel