Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul Mantissa HTTPS support #67

Open
mithrandi opened this issue Sep 15, 2017 · 0 comments
Open

Overhaul Mantissa HTTPS support #67

mithrandi opened this issue Sep 15, 2017 · 0 comments

Comments

@mithrandi
Copy link
Contributor

Currently Mantissa jumps through a lot of hoops to generate URLs with HTTPS when redirecting from HTTP, but only when logging in, etc. These hoops represent some rather outdated ideas about HTTPS; there isn't really any reason to serve only logged in stuff over HTTPS instead of just serving the whole site over HTTPS. I think we should instead have Mantissa only serve Mantissa web functionality over one port (be it HTTP or HTTPS; HTTP behind a TLS terminating proxy is a pretty common use case that we should still support), and if you want HTTP to HTTPS redirection we can have a site that specifically just redirects which you could hook up to an HTTP port.

This would remove the need for Mantissa to look for an SSLPort to redirect to, which currently breaks sites using EndpointPort, which we made the default. Oops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant