Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance test unexpected success in scrolltable #7

Open
mithrandi opened this issue Feb 7, 2015 · 2 comments
Open

Performance test unexpected success in scrolltable #7

mithrandi opened this issue Feb 7, 2015 · 2 comments
Labels

Comments

@mithrandi
Copy link
Contributor

[SUCCESS!?!]
Reason: 'Index scan to find appropriate storeID starting point once the value index has been used to seek to /near/ the correct starting place causes this to be O(N) on the number of rows with duplicate values.'

xmantissa.test.test_scrolltable.InequalityPerformanceTests.test_rowsAfterItemWithDuplicatesAtStart
xmantissa.test.test_scrolltable.InequalityPerformanceTests.test_rowsBeforeItemWithDuplicatesAtStart

This is probably not worth spending any brain cycles on since I think the plan was to deprecate scrolltable anyway.

@mithrandi mithrandi added the bug label Feb 7, 2015
@mithrandi
Copy link
Contributor Author

Oh, it was tdb that was going to be deprecated, not scrolltable. Well, maybe the .todo attribute should just be removed from these tests? I guess the SQLite query optimizer got smarter or something, although I think that just means the test isn't testing what it thinks it is anymore :/

@mithrandi
Copy link
Contributor Author

Turns out these tests don't failunexpectedly succeed on the older version of SQLite that Travis has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant