Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Cannot edit the domain associated with a multi-account website #100

Open
4 tasks done
ccornici opened this issue Sep 5, 2024 · 1 comment
Open
4 tasks done
Labels
Bug Something isn't working Future To do in the future

Comments

@ccornici
Copy link

ccornici commented Sep 5, 2024

NOTE: some might be tempted to say "this is a feature request". I get why you'd think that. But I think it's a bug. The point of the browser extension is to be synced with the phone and provide codes for accounts. Under the described scenario below, it cannot correctly provide codes for all accounts in question. So it's a bug.

Browser info

Irrelevant

Browser extension version

Irrelevant

Website

No response

Bug description

There are some websites where you can have multiple accounts to chose from. Example: Microsoft account login page.
In this particular case, of MS login page, each account has a specific URL like login.com/uuid1 for account 1 login.com/uuid2 for account 2.

2FAS saves only the base domain.
=> We get in a situation where 2FAS can only autofill codes for 1 account (whichever we happen to asociate it with)

Solution

We should be able to edit the 2FAS associated domain and as needed, such that we can obtain the following associations:

  • login.com/uuid1
  • login.com/uuid2

Each corresponding to a different account which requires different codes

Additional context

No response

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I understand that security vulnerabilities should be reported to [email protected] instead of on GitHub.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@ccornici ccornici added the Bug Something isn't working label Sep 5, 2024
@GrzegorzZajac000
Copy link
Member

Hi @ccornici,

Thank you for submitting this bug request. Your input is greatly appreciated, and we value the time you took to share your problem with us. However, after careful consideration, we have decided that we will not be able to prioritize this bug in the immediate future.

Our extension is based on domains, not on full URLs for now, so at the moment, you can remove default for login.com in Browser extension setting in edit of your service. Then for requests on login.com you can choose right service every time.

@GrzegorzZajac000 GrzegorzZajac000 added the Future To do in the future label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Future To do in the future
Projects
None yet
Development

No branches or pull requests

2 participants