Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 'oneof' with 'optional' #111

Open
alexjpwalker opened this issue Jan 25, 2021 · 1 comment
Open

Replace 'oneof' with 'optional' #111

alexjpwalker opened this issue Jan 25, 2021 · 1 comment
Assignees
@flyingsilverfin
Labels
priority: medium type: refactor

Comments

@alexjpwalker
Copy link
Member

Problem to Solve

We currently use oneof to denote an optional field. As of Protobuf 3.13+ this is no longer the standard, and is ugly.

Proposed Solution

Replace 'oneof' with 'optional' when all dependants are on Protobuf 3.13+
@flyingsilverfin flyingsilverfin self-assigned this Jan 10, 2023
@flyingsilverfin
Copy link
Member

We should use Protobuf's now-standard optional fields in the protocol when we move to TypeDB 3.0

@flyingsilverfin flyingsilverfin changed the title Replace 'oneof' with 'optional' when all dependants are on Protobuf 3.13+ Replace 'oneof' with 'optional' Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flyingsilverfin flyingsilverfin

Labels
priority: medium type: refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flyingsilverfin @alexjpwalker