Skip to content
This repository has been archived by the owner on Sep 25, 2020. It is now read-only.

tcurl should accept hostnames for the host when making a request #125

Open
prashantv opened this issue Apr 5, 2016 · 1 comment
Open

Comments

@prashantv
Copy link
Contributor

$ tcurl -p hyperbahn01-sjc1:21300 moe --health
NOT OK
Error response received for the as-thrift request.
AssertionError: Expected host to contain IPv4
{"ok":false,"name":"AssertionError","message":"Expected host to contain IPv4","isError":true,"isErrorFrame":false}
$ tcurl --version
4.19.1
@yhorbachov
Copy link

@prashantv tcurl uses tchannel to create connections, which has checking for valid IPv4 address. I don`t know why developers decided to check it (tchannel uses vanilla node 'net' module to create sockets, which accepts hostnames and IP addresses) but it is as it is.

I created issue in tchannel issues list Issue-327.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants