Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Grant Landing Page #622

Open
6 of 7 tasks
Vensberg opened this issue Oct 2, 2024 · 8 comments
Open
6 of 7 tasks

Testing Grant Landing Page #622

Vensberg opened this issue Oct 2, 2024 · 8 comments
Assignees

Comments

@Vensberg
Copy link
Collaborator

Vensberg commented Oct 2, 2024

Test date

10/2/2024

Reason for testing:

  • New feature
  • New data

Tasks

  • Compare Figma mockup against 2 completed and 2 active grants, including one with more than one PI
  • Impersonate a user using keycloak
  • Change visibility of a grant and confirm change in Elements
  • Confirm grant page disappears on reload
  • Reverse visibility through AE UI
@Vensberg Vensberg self-assigned this Oct 2, 2024
@Vensberg
Copy link
Collaborator Author

Vensberg commented Oct 3, 2024

Correct choice: the mockups have the amount showing, but correctly, the page does not display that.

@UcDust , currently the Grant Admin field displays the same entity as Awarded by. It is likely the data did not make it. While that is being inspected, please, hide the Grant Admin field until we know more. Troubleshooting will be done here: #624.

Invisible grants still have resolvable landing pages. When the grant visibility has been changed, the expected behavior is:

  1. If there are no public relationships, the grant landing page should return a 404 for all users, including the owner of the grant
  2. If there are other experts related to the grant, the grant landing page will continue to resolve, but
    --if the expert who changed the visibility setting is a PI or coPI, their name will continue to appear in the list of contributors, but not link back to their profile page
    --if that expert is a different type of contributor, they will be removed from the list of contributors

@UcDust
Copy link
Collaborator

UcDust commented Oct 3, 2024

@Vensberg

The first item of removing the grant admin field from the ui will be done in #625.

The second item for the 404 page when no public contributors, and other display preferences you outlined, will be done in #621.

@Vensberg
Copy link
Collaborator Author

10/15/2024
Retest

@UcDust, on this grant and this one Contributors are being duplicated. Also, can you make the font and letter case the same for linked and non-linked contributors?

@Vensberg
Copy link
Collaborator Author

The grant admin field has been successfully removed.

@Vensberg
Copy link
Collaborator Author

The 404 issue is almost done. What works well:

  • If the expert is the only person on the grant, it gives a 404
  • If the expert is a non-PI personnel, they disappear, the grant and PIs who are still at UCD stay
    What needs fixing
  • If the PI/coPI are no longer active UCD personnel, and the expert who changes the visibility on their grant to invisible is the last active link, this grant needs to give a 404 (example of that type of grant, with Quinn making that grant invisible should give 404)

@UcDust
Copy link
Collaborator

UcDust commented Oct 23, 2024

@Vensberg

The issue related to the 404 page from your last comment should now be fixed and on stage.

@qjhart
Copy link
Collaborator

qjhart commented Oct 23, 2024

@Vensberg stage is now at 2.2.3, incorporating #638, #636, and #632.
We can't fix duplicate names till version 2.3

@Vensberg
Copy link
Collaborator Author

@UcDust, looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants