Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Grants Search #672

Open
11 of 31 tasks
Vensberg opened this issue Dec 12, 2024 · 9 comments
Open
11 of 31 tasks

Testing Grants Search #672

Vensberg opened this issue Dec 12, 2024 · 9 comments
Assignees

Comments

@Vensberg
Copy link
Collaborator

Vensberg commented Dec 12, 2024

12/11/2024

Reason for testing:

  • New feature
  • New data: we got ~150 new users

Tasks

  • Impersonate a user using keycloak
  • Confirm works can be downloaded from the profile
  • Confirm grants can be downloaded from the profile
  • Navigate to their Edit Works; review citations
  • Download a single work
  • Change visibility of a work and confirm change in Elements
  • Reverse visibility through AE UI
  • Navigate to their Edit grants; review citations
  • Download a single grant
  • Change visibility of a grant and confirm change in Elements
  • Reverse visibility through AE UI
  • Search for avian flu. Confirm that searches have "search matches: # grants.
  • Test download on:
    - [ ] All Results--expert only
    - [x] Experts
    - [ ] Grants--no
    - [ ] Works (Currently N/A)
  • Under Experts check and uncheck Availability labels. Note that the number of experts changes appropriately.
  • Test download
  • Click on the # grant for one of the experts. A filter with the name should appear, and only those grants should be listed
  • Check download--no

More extensive testing

  • As an admin search for 0130. There should be only one hit
  • Edit user and hide that grant
  • Repeat search: confirm no results are returned
  • Review grants CSV download, particularly coPI list
  • Ask for a broken links review

Before a live demo

  • Download a RIS file of publications and test import into MIV
  • Test pulling grants into MIV

After a particularly major update

  • Go to Browse-->M. Check that pagination works right
  • Go to faculty with hundreds of publications: Check pagination again
  • Edit user: check that Add work redirects to Elements
  • Edit userL Check that bio fields redirect to Elements
  • New users are added
@Vensberg
Copy link
Collaborator Author

@UcDust , the grants are not currently download-able from Search --> All Results, Grants and Grants filtered by Expert.

@Vensberg
Copy link
Collaborator Author

@wrenaria, there is a # category in Expert Browse (I assume based on the Grants Browse). I wanted to confirm with you that choice.

@Vensberg
Copy link
Collaborator Author

Vensberg commented Dec 12, 2024

Search doesn't reset.
I did an initial search on "avian flu" and selected an expert.
Then I typed "lane". The search didn't change. The URL initially correctly had "lane" as the query, but a second click on the search changed it to ?q=lane&expert=expert/4gQyiBPO. The UI display of results didn't change (see screenshot). Also, the Select All for Download did not reset.
search

@Vensberg
Copy link
Collaborator Author

To address at a later time: when redirecting a user to add a bio/an intro to Elements, the landing page should be their profile in editing mode rather in viewing mode.

@UcDust
Copy link
Collaborator

UcDust commented Dec 12, 2024

@Vensberg @qjhart @wrenaria
I'm not sure how best to approach the grant download on the search page. Currently only experts can be downloaded there, and the headers for that data are:

Name | Aggie Experts Webpage | Number of works that match the keyword | Number of grants that match the keyword | URLs from the profile

What data should be extracted for grants? How should we handle when the download is a combination of both types of results? Also there's the new design for complex search results that's pending design, so not sure if that will affect when the changes here are delivered.

@Vensberg
Copy link
Collaborator Author

@UcDust , grants from the search-grants filter should be downloadable with the same headers as from the researcher's profile:

Title | Funding Agency | Grant Id | Start Date | End Date | Type of Grant | Role | List of PIs and CoPIs

Perhaps, for the time being Download of All Results should be disabled. Let's do that if Kimmy has no objections.

@Vensberg
Copy link
Collaborator Author

@UcDust , I realized Role is not helpful here as the grants are not attached to people in that filtered view. Can you make that a concatenated "Known Contributors" column?

@UcDust
Copy link
Collaborator

UcDust commented Dec 13, 2024

Search doesn't reset. I did an initial search on "avian flu" and selected an expert. Then I typed "lane". The search didn't change. The URL initially correctly had "lane" as the query, but a second click on the search changed it to ?q=lane&expert=expert/4gQyiBPO. The UI display of results didn't change (see screenshot). Also, the Select All for Download did not reset. search

I guess the intended behavior will be the following:

  • When filtered to an experts grants, searches will further refine the results for that expert. If you click on Expert or All Results, then the filter to that person will be removed.
  • New searches shouldn’t change the filter to all results, search should keep in current filter (ie experts or grants).

@Vensberg
Copy link
Collaborator Author

I guess the intended behavior will be the following:

* When filtered to an experts grants, searches will further refine the results for that expert. If you click on _Expert_ or _All Results_, then the filter to that person will be removed.

In both cases the filter should remain. In the described case the search+filters currently operate as expected

* New searches shouldn’t change the filter to all results, search should keep in current filter (ie experts or grants).

With a new search all existing filters should go away. In the example above, when the user types "Lane" and hit search, the search page should load All Results and the query should be search?q=lane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants