Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes null values in export function. #362

Merged
merged 2 commits into from
May 13, 2024
Merged

Fixes null values in export function. #362

merged 2 commits into from
May 13, 2024

Conversation

scherztc
Copy link
Contributor

@scherztc scherztc commented May 7, 2024

Fixes #337

The reason the spreadsheets were blank is that we had nil values for

tech_leads, departments, developers, product_owners, admin_users

We refactored this code by DRYing it up and introduced ERROR Handling for nil fields.

We also added a test for nil values.

@hortongn hortongn self-requested a review May 8, 2024 13:48
@hortongn hortongn self-assigned this May 8, 2024
Copy link
Member

@hortongn hortongn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scherztc This is great. Worked fine with my testing and the code is WAY better. One requested change: Join the multivalued fields with a ', ' (comma and a space) instead of just ','. It looks nicer in the spreadsheet if each value has a space after the comma.

@hortongn hortongn merged commit bce5cdf into qa May 13, 2024
4 checks passed
@hortongn hortongn deleted the fix/export branch May 13, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exports to CSV are blank
2 participants