Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Notification Undefined Behavior #74

Open
kanielv opened this issue Sep 20, 2024 · 4 comments · Fixed by #77
Open

Local Notification Undefined Behavior #74

kanielv opened this issue Sep 20, 2024 · 4 comments · Fixed by #77
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@kanielv
Copy link
Collaborator

kanielv commented Sep 20, 2024

Expected Behavior

When the user adds an alarm for a specific time, a local notification should appear saying the alarm went off. If the alarm is on repeat, then it should repeat again the next day at the same time. The user should also be able to disable this alarm.

Current Behavior

Alarm notification pops up despite the alarm being turned off or deleted. The time when the alarm goes off is not accurate to the time set (off by an hour).

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. In the alarms tab set up an alarm (Set Alarm Time).
  2. Configure an alarm and save it.
@kanielv kanielv added bug Something isn't working good first issue Good for newcomers labels Sep 20, 2024
@carlsuarez
Copy link
Contributor

Could I work on this issue?

@kanielv
Copy link
Collaborator Author

kanielv commented Sep 24, 2024

Could I work on this issue?

Sure!

@carlsuarez
Copy link
Contributor

I fixed the issues with notifications triggering at the wrong time and the delete functionality. However, I'm having trouble with the "turn off" feature for alarms. Since Expo doesn't support rescheduling or disabling notifications, turning off an alarm would mean deleting it entirely, which would also remove the alarm card in the current implementation. Implementing a proper solution would require major code changes, and I don’t have time for that right now. If you'd like, I can open a PR for the issues I’ve already fixed.

@kanielv
Copy link
Collaborator Author

kanielv commented Sep 25, 2024

Of course. I'll take it a look at it and merge it if it looks good. I'll open another issue for properly deleting the an Alarm. Thanks for the help!

@kanielv kanielv linked a pull request Sep 26, 2024 that will close this issue
@kanielv kanielv removed a link to a pull request Sep 26, 2024
@kanielv kanielv linked a pull request Sep 26, 2024 that will close this issue
@kanielv kanielv added the help wanted Extra attention is needed label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants