Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OAuth for Google sign in with Firebase Auth #234

Open
AlexanderWangY opened this issue Aug 30, 2024 · 15 comments
Open

Implement OAuth for Google sign in with Firebase Auth #234

AlexanderWangY opened this issue Aug 30, 2024 · 15 comments
Assignees
Labels
Feature New feature or request Frontend 🖥 Issues corresponding to the frontend/client. Medium You should have some familiarity with our codebase to work on this issue

Comments

@AlexanderWangY
Copy link
Collaborator

Just like the title, allow users to sign in using OAuth and the google sign in option. This should be hooked up to the google icon in the home and signup and log in screen! This should also update the user in the store so they are automatically signed in!

@AlexanderWangY AlexanderWangY added Feature New feature or request Frontend 🖥 Issues corresponding to the frontend/client. Medium You should have some familiarity with our codebase to work on this issue labels Aug 30, 2024
@Drayiss
Copy link
Contributor

Drayiss commented Sep 5, 2024

I would like to be assigned this issue. I will be attending the Casual Codings at OSC. If I am new to this repo and all the tech stack involved, could I still reasonably complete this within the next month? Thanks.

@Drayiss
Copy link
Contributor

Drayiss commented Sep 5, 2024

Nevermind, I will wait for an easier issue for now.

@topo123
Copy link

topo123 commented Sep 6, 2024

I would like to be assigned this issue please. Thank you.

@AlexanderWangY
Copy link
Collaborator Author

Sounds good! Let me know if you any questions.

@dyland88
Copy link
Collaborator

Update?

@dyland88
Copy link
Collaborator

dyland88 commented Oct 1, 2024

Any new updates?

@topo123
Copy link

topo123 commented Oct 2, 2024

Yeah, so I've done most of it, and I just wanted to know if I am allowed to add external libraries to the project. If I can I'm having trouble getting reactive native google sign in library to link. Any help will be much appreciated. This is the error I'm getting Invariant Violation: TurboModuleRegistry.getEnforcing(...): 'RNGoogleSignin' could not be found. Verify that a module by this name is registered in the native binary.Bridgeless mode.

@dyland88
Copy link
Collaborator

dyland88 commented Oct 2, 2024

You can totally use external libraries! Implementing google sign in without using anything sounds quite difficult lol.
I'd have to look at your code at casual coding to try to figure out what's going on with your error. Until then, I would definitely look up your error and see if there's anything on stack overflow that might figure out what's going on.

@topo123
Copy link

topo123 commented Oct 2, 2024

Ok from what I have found the google sign in library doesn't work with expo, and you have to build it in a specific way for an emulator or use an eas build for an emulator, or have a mac to run it with xcode.

@topo123
Copy link

topo123 commented Oct 3, 2024

Can I use an android emulator to run tests for my google sign in code, because expo go does not support using custom react native code. Trying to make an eas build requires a paid apple developer account as well as development builds.

@dyland88
Copy link
Collaborator

dyland88 commented Oct 3, 2024

That's interesting that you can't use expo with Google sign-in. Since that's the case, you can totally use Android emulators to test it out too.

@topo123
Copy link

topo123 commented Oct 3, 2024

Getting an issue that someone messed up directory for the assets. Wrong path to some files used in the app so I can’t build the android app

@dyland88
Copy link
Collaborator

dyland88 commented Oct 3, 2024

Did it work before? What changed since it was working before?

@topo123
Copy link

topo123 commented Oct 3, 2024

When it was running on expo go worked fine. When trying to build the files for the android emulator it breaks due to the file paths being wrong for the assets. It tries to access some png file in the assets directory but there are only folders in that directory.

@dyland88
Copy link
Collaborator

dyland88 commented Oct 3, 2024

How odd. I'll have to look into that more at CC today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request Frontend 🖥 Issues corresponding to the frontend/client. Medium You should have some familiarity with our codebase to work on this issue
Projects
None yet
Development

No branches or pull requests

4 participants