Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implimented prittier into the github action #256

Closed
wants to merge 3 commits into from

Conversation

BaisonBeast
Copy link
Contributor

@BaisonBeast BaisonBeast commented Sep 6, 2024

I have tried to implement pritter check into the GitHub actions.
Fixes #253

fi

- name: Check Prettier Formatting
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make this its own separate job? Right now its running underneath the file existence job.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you pls check now

@h1divp
Copy link
Collaborator

h1divp commented Sep 7, 2024

Maybe I didn't make it clear enough in my issue, but this isn't really meant to be change to our github actions, we already have ESLint to fix small really really minute bugs, though it still does need to be fixed.

Prettier is something that you can install as an extension into VS Code for instance, where it will automatically format whitespace (and similar things) every time you save the file you're currently working on. If many people were to use this, our codebase would become much more consistent stylistically.

That said, the issue I proposed would essentially be installing prettier as a development tool (npm i --save-dev) and creating the configuration file that would be laying in the project base directories for client and server. So when someone does install Prettier into their editor, the configuration it needs to be in line with the project is already there for them.

I will respecify this in my issue.

https://prettier.io/docs/en/comparison.html

@h1divp
Copy link
Collaborator

h1divp commented Sep 7, 2024

There are also a lot of configuration options. I would look up a default configuration that seems pretty standard for typescript, run it by a tech lead or leave a comment in the issue, and then move forward with approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Prettier linting to project
3 participants