Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have current-client user profile picture/display name be rendered in the chat screen #290

Open
h1divp opened this issue Sep 17, 2024 · 5 comments
Assignees
Labels
Easy A simple problem or change that needs to be fixed or made. Feature New feature or request Frontend 🖥 Issues corresponding to the frontend/client.

Comments

@h1divp
Copy link
Collaborator

h1divp commented Sep 17, 2024

For #254. Note that this change only pertains to the currently logged in user and not for the messages received from other users.

Summary

Currently, the user is able to set their profile picture (a numbered image, and color hex code), and their display name (string) through the Settings Screen.

These are saved as state within the settings page. However, we need to make sure that these settings:

  1. Add and update their respecting parameters in the Settings Store so that they can be accessed anywhere in the app. The Store also keeps these parameters saved locally between logins.
  2. Actually render properly for any message that the logged in user sends, particularly in ChatMessage.tsx which state is passed to by the Message Channel (which is used in the Chat Screen).

After making these changes, create a PR and mention the Issue Number for this issue (so that it can close automatically after a merge).
Comment below to be assigned.

@h1divp h1divp added Feature New feature or request Easy A simple problem or change that needs to be fixed or made. Frontend 🖥 Issues corresponding to the frontend/client. labels Sep 17, 2024
@Nqnt41
Copy link

Nqnt41 commented Sep 18, 2024

I can give this a shot over the next few days, if thats alright.

@Nqnt41
Copy link

Nqnt41 commented Sep 20, 2024

Update: During CC yesterday I got a grasp on how to implement the first goal. Will mess with implementing the second goal over the weekend and hopefully try to finish it during CC Tuesday, depending on how things go over the weekend.

@h1divp
Copy link
Collaborator Author

h1divp commented Sep 27, 2024

Thank you for updating

@Nqnt41
Copy link

Nqnt41 commented Oct 17, 2024

Giving another update: still working on the issue, have just had a messy few weeks. Going to try to wrap it up soon if possible.

@Nqnt41
Copy link

Nqnt41 commented Oct 29, 2024

Sent out a Pull Request for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy A simple problem or change that needs to be fixed or made. Feature New feature or request Frontend 🖥 Issues corresponding to the frontend/client.
Projects
None yet
Development

No branches or pull requests

2 participants